-
-
Notifications
You must be signed in to change notification settings - Fork 23.7k
Always create a .gitignore in .godot
#112068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This makes the default
Although the change is questionable. It assumes that the user will use git with their project, but they might use another VCS or no VCS at all, resulting in unnecessary file. It is harmless however. |
|
To be clear, this does not assume that users will always use git, but provide a safe default behavior whenever the project is added to git. Any project will work. Projects can be those that didn't select Git during creation, or even those not created by the standard project manager. It's different from generating the file in the project root since |
200c1ad to
a033888
Compare
|
Could the In this case, we wouldn't need a top-level |
|
I think adding the same in the I would keep |
a033888 to
e088859
Compare
|
Updated.
|
KoBeWi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks ok.
Though it feels a bit odd that the default .gitignore is created with comments only 🤔
Also, while .godot should always be ignored, there are people that commit it to VCS and with this PR it's effectively no longer possible (but IMO it's not a problem).
Ignored files can be added by using the |
|
Yeah, but you'll need to do it every time. And not sure if it's easily possible when using git GUI (e.g. in VS Code). |
Closes godotengine/godot-proposals#13468
Always create res://.godot/.gitignore with * as its content.
This way, even if Git metadata isn't added when the project is created, adding the project to Git later is still safe by default.